Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: form elements border color #3598

Closed
wants to merge 4 commits into from
Closed

fix: form elements border color #3598

wants to merge 4 commits into from
+1 −1

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Dec 12, 2024 •
edited
Loading

Proposed changes

Currently the form elements border are failing WCAG Success Criteria 1.4.11, as the contrast ration doesn't meet the minimum of 3:1 to their underlaying background color. This ticket changes all elements borders with a 60er color to 70.

DBUXDS-4044

Most likely we'll proceed with #3601

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added 🐛bug Something isn't working 👂accessibility Accessibility issues/improvements labels Dec 12, 2024
@mfranzke mfranzke self-assigned this Dec 12, 2024
@github-actions github-actions bot added the 🏘components Changes inside components folder label Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-form-elements-border-color

@nmerget
Copy link
Member

nmerget commented Dec 16, 2024

@mfranzke can we close this one?

@mfranzke mfranzke closed this Dec 16, 2024
@mfranzke mfranzke deleted the fix-form-elements-border-color branch December 16, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget Awaiting requested review from nmerget nmerget will be requested when the pull request is marked ready for review nmerget is a code owner

@annsch annsch Awaiting requested review from annsch annsch will be requested when the pull request is marked ready for review annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch will be requested when the pull request is marked ready for review bruno-sch is a code owner

Assignees

@mfranzke mfranzke

Labels
👂accessibility Accessibility issues/improvements 🐛bug Something isn't working 🏘components Changes inside components folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfranzke @nmerget